Add check get category

[zonky2]

With the customisation, other hooks can also customise the list.

[fritzmg]

You can also give your Hook a higher priority.

[zonky2]

You can also give your Hook a higher priority.

I set the other hook (https://github.com/numero2/contao-tags) a priority = 100 - without the PR I see
Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\NotFoundHttpException: "Unused arguments: category" at /html/contao4/vendor/contao/core-bundle/src/EventListener/ExceptionConverterListener.php line 97

see numero2/contao-tags#6

[fritzmg]

Yes, your own Hook will then need to process the category. Or what exactly is your goal?

[zonky2]

There are two different news listings - one list can be filtered by category, the other by tags.

This does not work with the previous implementations.

[fritzmg]

This needs to be fixed differently then. If category filtering is not enabled, then the hook needs to return false.

But you will also have to make sure, that category URLs do not point to the wrong news list.

[fritzmg]

In any case, this cannot be merged as is, as there are a few problems:

• The category parameter is hardcoded, instead of being fetched from the manager.
• This would break the standard filter functionality (i.e. filtering by categories, even without an active category).
• Input::get($categoryParam) should probably not be executed here without the 3rd parameter being true.
• Only newsListFetchItems was adjusted, instead of both hooks, leading to inconsistent behaviour.

But as already mentioned, the actual solution needs to be implemented completely differently. In essence the the hooks need to return false if only the standard Contao behaviour applies (or should apply).

[aschempp]

does the hook in news-categories need to return false, or some other place?

[zonky2]

https://github.com/numero2/contao-tags/blob/1f9c9b7c55dc7eaa20ede807239dc50d2f87bfff/src/EventListener/NewsListener.php#L154
and
https://github.com/numero2/contao-tags/blob/1f9c9b7c55dc7eaa20ede807239dc50d2f87bfff/src/EventListener/NewsListener.php#L223

[fritzmg]

does the hook in news-categories need to return false, or some other place?

Yes - basically if $criteria = $this->getCriteria() only adds the basic criteria and nothing else then the hooks need to return false. Not sure how this could be done while keeping the same structure. May be add something like NewsCriteria::isOnlyBasicCriteria() and then keep track of that in the other functions?

[fritzmg]

@aschempp @qzminski if you agree, I can try a PR.

[aschempp]

I have no opinion, but feel free to give it a try 😅

[fritzmg]

See #263