Fixing problems with current jenkins version #15
Conversation
* Fixed certain small issues ** Check for FINISHED or FINALIZED phase ** Use job_url to find lastFailedBuild, because a job name can contain blanks ** Look for the correct username (in case we use authentication '/user/' finds the logged in user and not the commited by user name)
|
I hope you can add this fix to your project. thx Tommy |
|
Hi Tommy. Looks good. Was the driver for the change to make the code compatible with latest version of Jenkins, or the space in the job name? I'll merge this in, but I wonder if I should also update the README with a version compatibility note? |
|
Both cases was the driver in my environment. When you wanna be just compatible with the latest jenkins version, you need of course just the phase checking code. But we use also some jobs with blanks and that's why I fixed both issues. For more informations about the jerkins version and since when they changed it, I would need to have a deeper look on the jenkins project. Yes a small NOTE is always useful. |
|
Hi, |
|
Could you please let me know about the pull into your repo? |
** Check for FINISHED or FINALIZED phase
** Use job_url to find lastFailedBuild, because a job name can contain blanks
** Look for the correct username (in case we use authentication '/user/' finds the logged in user and not the commited by user name)