Use the upload.id as parallel_idx
#720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 98.09% 98.08% -0.01%
==========================================
Files 432 432
Lines 36327 36294 -33
==========================================
- Hits 35634 35600 -34
- Misses 693 694 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 98.09% 98.08% -0.01%
==========================================
Files 432 432
Lines 36327 36294 -33
==========================================
- Hits 35634 35600 -34
- Misses 693 694 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 98.09% 98.08% -0.01%
==========================================
Files 432 432
Lines 36327 36294 -33
==========================================
- Hits 35634 35600 -34
- Misses 693 694 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 98.09% 98.08% -0.01%
==========================================
Files 432 432
Lines 36327 36294 -33
==========================================
- Hits 35634 35600 -34
- Misses 693 694 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Swatinem
force-pushed
the
swatinem/fix-sessionid-allocation
branch
from
1e40b96
to
cdf4bba
Compare
Swatinem
force-pushed
the
swatinem/fix-sessionid-allocation
branch
2 times, most recently
from
3a9f322
to
c1793fe
Compare
Swatinem
changed the title
session.id/order_number from the upload.idupload.id as parallel_idx
This way, the `parallel_idx` is fully unique. Then later when merging the reports together, each parallel report session will change its index according to what the next session_id within the aggregated Report will be.
Swatinem
force-pushed
the
swatinem/fix-sessionid-allocation
branch
from
c1793fe
to
afe4287
Compare
giovanni-guidini
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the
parallel_idxis fully unique.Then later when merging the reports together, each parallel report session will change its index according to what the next session_id within the aggregated Report will be.