WIP #549
WIP #549
Conversation
| @@ -88,6 +88,13 @@ def db(engine, sqlalchemy_connect_url): | |||
| Base.metadata.create_all(engine) | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="session") | |||
There was a problem hiding this comment.
Fixture to avoid django trying to recreate a DB and instead pointing to the preexisting DB
| @@ -105,6 +111,31 @@ class Owner(CodecovBaseModel): | |||
| passive_deletes=True, | |||
| ) | |||
|
|
|||
| business_email = Column(types.Text, server_default=FetchedValue()) | |||
There was a problem hiding this comment.
Missing fields from SQLAlchemy model compared to it's Django counterpart
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #549 +/- ##
===========================================
- Coverage 97.51% 85.86% -11.65%
===========================================
Files 420 420
Lines 35432 35437 +5
===========================================
- Hits 34550 30428 -4122
- Misses 882 5009 +4127
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #549 +/- ##
===========================================
- Coverage 97.51% 85.86% -11.65%
===========================================
Files 420 420
Lines 35432 35437 +5
===========================================
- Hits 34550 30428 -4122
- Misses 882 5009 +4127
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 97.53% 94.45% -3.08%
==========================================
Files 451 451
Lines 36155 36489 +334
==========================================
- Hits 35263 34466 -797
- Misses 892 2023 +1131
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 64 files with indirect coverage changes This change has been scanned for critical changes. Learn more |
|
Closing in favor of new PR |
This PR is to import token/bot logic from shared and replace its previous implementation in worker. This is WIP as of July 8th
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.