Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only process flakes for head of pull #548

Closed
wants to merge 2 commits into from

Conversation

joseph-sentry
Copy link
Contributor

instead of processing all the commits on a pull that was merged, it's
more correct to process only the testinstances that occurred on the head
of the pull, since we can only guarantee that the test instances on the
head of the pull are reflective of the state of the code on main.

instead of processing all the commits on a pull that was merged, it's
more correct to process only the testinstances that occurred on the head
of the pull, since we can only guarantee that the test instances on the
head  of the pull are reflective of the state of the code on main.
@joseph-sentry joseph-sentry marked this pull request as ready for review July 8, 2024 14:35
@codecov-notifications
Copy link

codecov-notifications bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         420      420           
  Lines       35407    35407           
=======================================
  Hits        34526    34526           
  Misses        881      881           
Flag Coverage Δ
integration 97.51% <0.00%> (ø)
latest-uploader-overall 97.51% <0.00%> (ø)
unit 97.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <0.00%> (ø)
OutsideTasks 97.74% <0.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (d1c1caf) to head (daca8ac).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         420      420           
  Lines       35407    35407           
=======================================
  Hits        34526    34526           
  Misses        881      881           
Flag Coverage Δ
integration 97.51% <0.00%> (ø)
latest-uploader-overall 97.51% <0.00%> (ø)
unit 97.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <0.00%> (ø)
OutsideTasks 97.74% <0.00%> (ø)

Copy link

codecov-public-qa bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (d1c1caf) to head (daca8ac).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         420      420           
  Lines       35407    35407           
=======================================
  Hits        34526    34526           
  Misses        881      881           
Flag Coverage Δ
integration 97.51% <0.00%> (ø)
latest-uploader-overall 97.51% <0.00%> (ø)
unit 97.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <0.00%> (ø)
OutsideTasks 97.74% <0.00%> (ø)

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (d1c1caf) to head (daca8ac).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         451      451           
  Lines       36129    36129           
=======================================
  Hits        35238    35238           
  Misses        891      891           
Flag Coverage Δ
integration 97.51% <0.00%> (ø)
latest-uploader-overall 97.51% <0.00%> (ø)
unit 97.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.63% <0.00%> (ø)
OutsideTasks 97.74% <0.00%> (ø)

This change has been scanned for critical changes. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant