fix: only process flakes for head of pull #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of processing all the commits on a pull that was merged, it's more correct to process only the testinstances that occurred on the head of the pull, since we can only guarantee that the test instances on the head of the pull are reflective of the state of the code on main.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #545 +/- ##
==========================================
- Coverage 97.51% 97.51% -0.01%
==========================================
Files 420 420
Lines 35432 35429 -3
==========================================
- Hits 34550 34547 -3
Misses 882 882
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #545 +/- ##
==========================================
- Coverage 97.51% 97.51% -0.01%
==========================================
Files 420 420
Lines 35432 35429 -3
==========================================
- Hits 34550 34547 -3
Misses 882 882
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #545 +/- ##
==========================================
- Coverage 97.51% 97.51% -0.01%
==========================================
Files 420 420
Lines 35432 35429 -3
==========================================
- Hits 34550 34547 -3
Misses 882 882
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
- Coverage 97.53% 97.53% -0.01%
==========================================
Files 451 451
Lines 36155 36152 -3
==========================================
- Hits 35263 35260 -3
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
adrian-codecov
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of processing all the commits on a pull that was merged, it's more correct to process only the testinstances that occurred on the head of the pull, since we can only guarantee that the test instances on the head of the pull are reflective of the state of the code on main.