chore: don't delete comments. #543
Conversation
Currently the `require_changes` will deelte an existing comment if the requirements are not met but a commit exists. The commit vanishes without trace, which is not great UX. To improve UX we are changing this behavior to bypass required changes if a comment already exists for that PR. We will update that comment. We did verify that this does not trigger a new email being sent to users, so it should be fine. closes: codecov/engineering-team#2023
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #543 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 420
Lines 35432 35407 -25
=======================================
- Hits 34550 34526 -24
+ Misses 882 881 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #543 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 420
Lines 35432 35407 -25
=======================================
- Hits 34550 34526 -24
+ Misses 882 881 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #543 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 420
Lines 35432 35407 -25
=======================================
- Hits 34550 34526 -24
+ Misses 882 881 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 451 451
Lines 36155 36129 -26
=======================================
- Hits 35263 35238 -25
+ Misses 892 891 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
| @@ -207,6 +204,12 @@ async def check_condition_OR_group( | |||
| async def check_condition( | |||
| notifier: AbstractBaseNotifier, comparison: ComparisonProxy | |||
| ) -> bool: | |||
| if comparison.pull and comparison.pull.commentid: | |||
| log.info( | |||
There was a problem hiding this comment.
Should this be a warning?
There was a problem hiding this comment.
I don't think so... It's the expected behavior after all.
I'm adding this just to help us with debugging in the future
I think it should be on a separate ticket if we decide to remove that functionality, yes. |
Currently the
require_changeswill deelte an existing comment if the requirements are not met but a commit exists. The commit vanishes without trace, which is not great UX.To improve UX we are changing this behavior to bypass required changes if a comment already exists for that PR. We will update that comment.
We did verify that this does not trigger a new email being sent to users, so it should be fine.
closes: codecov/engineering-team#2023
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.