Make PythonStandardRunner include curr dir by default #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that when you package the CLI in PyInstaller, if you don't have the curr dir in PATH there's a high probability that pytest will fail because of the pytest plugins (it won't find them) So it's better to add the current dir by default to avoid issues. On top of that also adding `params` in the runner interface so we can log the params of the selected runner.
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 64 64
Lines 2013 2014 +1
=======================================
+ Hits 1904 1905 +1
Misses 109 109
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dana-yaish
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that when you package the CLI in PyInstaller, if you don't have the curr dir in PATH there's a high probability that pytest will fail because of the pytest plugins (it won't find them)
So it's better to add the current dir by default to avoid issues.
On top of that also adding
paramsin the runner interface so we can log the params of the selected runner.