bundle analysis upload endpoint add custom compare SHA #649
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 621 621
Lines 16567 16572 +5
=======================================
+ Hits 15166 15171 +5
Misses 1401 1401
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 621 621
Lines 16567 16572 +5
=======================================
+ Hits 15166 15171 +5
Misses 1401 1401
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
===========================================
Coverage 95.94000 95.94000
===========================================
Files 799 799
Lines 17884 17889 +5
===========================================
+ Hits 17158 17163 +5
Misses 726 726
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ai-review-prompt-prod testing out the production AI PR Review. You can ignore the recommendations if you get any. |
| @@ -73,6 +76,9 @@ def post(self, request): | |||
| else: | |||
| raise NotAuthenticated() | |||
|
|
|||
| if repo is None: | |||
There was a problem hiding this comment.
The authentication classes don't check if the repo exists already?
(asking for my own understanding)
There was a problem hiding this comment.
I don't believe so, I just added this to appease the type checker because if the repo doesn't exist it will just report null for the repo var.
closes codecov/engineering-team#2009
Add a
compareShaparam to the BA upload endpoint, this allows overriding default way of fetching comparison commit SHAs (ie Pull.compare_to or Commit.parent) with the current uploaded commit. This will be used as a solution for handling the "pre-merge commit" issue. This param will be consumed by the BundleAnalysisProcessor.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.