Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Fix GQL casing inconsistency throughout API #610

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ajay-sentry
Copy link
Contributor

Purpose/Motivation

The default object case behavior is deprecated: snake case fallback resolver
Ariadne calls out convert_names_case as the new correct way to convert case names

This PR aims to update all the inconsistencies throughout API and consequently, this also means we can remove all the instances of @convert_kwargs_to_snake_case in a followup!

Follow up ticket: codecov/engineering-team#1879

Links to relevant tickets

Closes codecov/engineering-team#1881

What does this PR do?

PR updates all the camelCasing throughout the graphQL layer to snake_casing since we get it for free now with the new schema option

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@ajay-sentry ajay-sentry requested a review from a team as a code owner June 7, 2024 22:08
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (0ee2d5c) to head (d4737e2).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #610   +/-   ##
===========================================
  Coverage   95.92000   95.92000           
===========================================
  Files           793        793           
  Lines         17689      17689           
===========================================
  Hits          16969      16969           
  Misses          720        720           
Flag Coverage Δ
unit 91.49% <100.00%> (ø)
unit-latest-uploader 91.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (0ee2d5c) to head (d4737e2).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         615      615           
  Lines       16371    16371           
=======================================
  Hits        14978    14978           
  Misses       1393     1393           
Flag Coverage Δ
unit 91.49% <100.00%> (ø)
unit-latest-uploader 91.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...commands/owner/interactors/save_terms_agreement.py 100.00% <ø> (ø)
graphql_api/schema.py 100.00% <100.00%> (ø)
graphql_api/types/commit/commit.py 100.00% <100.00%> (ø)
...ion/activate_measurements/activate_measurements.py 100.00% <ø> (ø)
...ql_api/types/mutation/cancel_trial/cancel_trial.py 100.00% <100.00%> (ø)
...es/mutation/create_user_token/create_user_token.py 100.00% <ø> (ø)
...ypes/mutation/erase_repository/erase_repository.py 100.00% <100.00%> (ø)
...upload_token/regenerate_repository_upload_token.py 100.00% <ø> (ø)
...phql_api/types/mutation/start_trial/start_trial.py 100.00% <100.00%> (ø)
...es/mutation/update_repository/update_repository.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (0ee2d5c) to head (d4737e2).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         615      615           
  Lines       16371    16371           
=======================================
  Hits        14978    14978           
  Misses       1393     1393           
Flag Coverage Δ
unit 91.49% <100.00%> (ø)
unit-latest-uploader 91.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...commands/owner/interactors/save_terms_agreement.py 100.00% <ø> (ø)
graphql_api/schema.py 100.00% <100.00%> (ø)
graphql_api/types/commit/commit.py 100.00% <100.00%> (ø)
...ion/activate_measurements/activate_measurements.py 100.00% <ø> (ø)
...ql_api/types/mutation/cancel_trial/cancel_trial.py 100.00% <100.00%> (ø)
...es/mutation/create_user_token/create_user_token.py 100.00% <ø> (ø)
...ypes/mutation/erase_repository/erase_repository.py 100.00% <100.00%> (ø)
...upload_token/regenerate_repository_upload_token.py 100.00% <ø> (ø)
...phql_api/types/mutation/start_trial/start_trial.py 100.00% <100.00%> (ø)
...es/mutation/update_repository/update_repository.py 100.00% <100.00%> (ø)

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Fix GQL casing inconsistency
1 participant