-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Fix GQL casing inconsistency throughout API #610
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
===========================================
Coverage 95.92000 95.92000
===========================================
Files 793 793
Lines 17689 17689
===========================================
Hits 16969 16969
Misses 720 720
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #610 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 615 615
Lines 16371 16371
=======================================
Hits 14978 14978
Misses 1393 1393
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #610 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 615 615
Lines 16371 16371
=======================================
Hits 14978 14978
Misses 1393 1393
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Purpose/Motivation
The default object case behavior is deprecated: snake case fallback resolver
Ariadne calls out convert_names_case as the new correct way to convert case names
This PR aims to update all the inconsistencies throughout API and consequently, this also means we can remove all the instances of @convert_kwargs_to_snake_case in a followup!
Follow up ticket: codecov/engineering-team#1879
Links to relevant tickets
Closes codecov/engineering-team#1881
What does this PR do?
PR updates all the camelCasing throughout the graphQL layer to snake_casing since we get it for free now with the new schema option
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.