This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
For issue #45 (Support for parameterized types) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peRef2JavaType so they can serve as hints for generic types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch lets Jerkson work with parameterized case classes by extracting type parameters using javaType.containedType, stashing them in a Map, and passing them through to typeRef2JavaType. In turn, typeRef2JavaType will return the stashed JavaTypes if it encounters one of them instead of trying to load classes using a generic name (which leads to a ClassNotFoundException). The patch series also includes a couple of test cases.
There might be a nicer way to accomplish the same thing but I am not aware of one.