Merges the contents of the long running cloud-20 branch into main #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantapop
force-pushed
the
fantapop/cloud-20
branch
from
062cc85
to
8ddf2c4
Compare
fantapop
force-pushed
the
fantapop/cloud-20
branch
from
8ddf2c4
to
4b47f49
Compare
fantapop
changed the title
fantapop
force-pushed
the
fantapop/cloud-20
branch
from
9ac1bb1
to
7d16bc7
Compare
This update includes all the cloud 2.0 changes.
Use new plan types. Remove support for spend limits. Add support for provisioned clusters. Adjust to use *int64 for usage limit fields rather than int64.
Previously, the TF provider raised an error when the primary attribute was
specified in multiple regions, even when false in all but one region, e.g.:
regions = [
{
name = "eu-west-1"
primary = true
},
{
name = "eu-west2"
primary = false
},
{
name = "ap-south-1"
primary = false
},
]
This PR fixes that by adding some custom validation logic rather than using
the built-in config validators.
Fixes: CC-27160
Make the "plan" attribute on the "cluster" resource writable so that it can be set by users who intend to upgrade/downgrade the plan. Keep the attribute as computed so that the system will set the value if it is not provided by the user. Release note: Support upgrade of plans via changes to the "plan" attribute on the "cluster" resource.
Rename the `provisioned_capacity` field to `provisioned_virtual_cpus` and update all tests and examples to use the vCPUs unit rather than request units by dividing by 500. This is part of the overall migration to vCPUs for Cloud 2.0.
Add tests for downgrading from the STANDARD plan to the BASIC plan.
Previously, the Plan field was not passed to the CreateCluster API, even if it was explicitly set by the user. This prevented the server from validating the cluster configuration. For example, the server was not able to return an error when Plan=BASIC and provisioned_virtual_cpus are set. The fix is to pass the Plan field to CreateCluster if the user explicitly sets it.
upgrade_type is now added for BASIC and STANDARD clusters. It can be used to dictate how the cluster handles major version upgrades. Valid values for upgrade_type are AUTOMATIC and MANUAL. BASIC clusters support only AUTOMATIC upgrades.
fantapop
force-pushed
the
fantapop/cloud-20
branch
from
7d16bc7
to
8542d8f
Compare
|
There were 2 errors during the acceptance test runs. Both of which seem unrelated to this branch so I'm going to merge it down. It has now been rebased to use the tagged version of the For posterity, the errors were: and === NAME TestAccMetricExportPrometheusConfigResource |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains all of the cloud 2.0 commits which we'll now merge back into main. Updating to the latest SDK also caused a merge conflict due to the list minute decision to rename provisioned_vcpus to provisioned_virtual_cpus. That change was rebased into each of the commits in this list.
Additionally there is a commit on top to tag the provider release to 1.8.0.
Commit checklist