private_endpoints_service: wait for all regions #221
+118
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when waiting for private endpoints service creation, the resource could be considered ready if a single resource was ready and others were not yet created. This commit fixes the bug by explicitly waiting for all regional services to be AVAILABLE.
fantapop
approved these changes
Jul 11, 2024
| } | ||
| ) (*client.PrivateEndpointServices, *retry.RetryError) { | ||
| // Set of all regions. | ||
| regions := func() map[string]bool { |
There was a problem hiding this comment.
nit: I think renaming this could help code readability later in this function
Suggested change
| regions := func() map[string]bool { | |
| pendingClusterRegions := func() map[string]bool { |
|
also It looks like the doc generation action is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when waiting for private endpoints service creation, the resource could be considered ready if a single resource was ready and others were not yet created. This commit fixes the bug by explicitly waiting for all regional services to be AVAILABLE.
Commit checklist
make generate)