Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: add services map to private_endpoint_services #219

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

carloruiz
Copy link
Contributor

@carloruiz carloruiz commented Jun 18, 2024

Previously, the private_endpoint_services resource contains the regional services in a list. This made it hard for users to access the service for a given region. This commit adds a service map that contains all the services but are keyed by the cloud region.

Commit checklist

  • Changelog
  • Doc gen (make generate)
  • Integration test(s)
  • Acceptance test(s)
  • Example(s)

@carloruiz carloruiz requested a review from fantapop June 18, 2024 23:49
@carloruiz carloruiz force-pushed the add-services-map-to-pes branch 4 times, most recently from 7668288 to 8a18746 Compare June 19, 2024 01:06
Copy link
Collaborator

@fantapop fantapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the aws_privatelink workflow to use the new map as well? It seems like this should be the preferred usage we recommend.

@carloruiz carloruiz requested a review from fantapop June 19, 2024 01:44
@carloruiz carloruiz force-pushed the add-services-map-to-pes branch 2 times, most recently from 37872c6 to c1e6c25 Compare June 19, 2024 02:01
Previously, the private_endpoint_services resource contains the regional
services in a list. This made it hard for users to access the service
for a given region. This commit adds a service map that contains all the
services but are keyed by the cloud region.
Copy link
Collaborator

@fantapop fantapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Thank you for adding this!

@carloruiz carloruiz merged commit bc77c78 into main Jun 19, 2024
4 checks passed
@carloruiz carloruiz deleted the add-services-map-to-pes branch June 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants