-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a warning to the README about the need to use a recent version of the provider for private endpoints #218
Merged
marksoper
merged 11 commits into
main
from
marksoper-patch-private-endpoint-version-warning
Jun 20, 2024
Merged
Adding a warning to the README about the need to use a recent version of the provider for private endpoints #218
marksoper
merged 11 commits into
main
from
marksoper-patch-private-endpoint-version-warning
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a warning to the README about the need to use a recent version of the provider for private endpoints to avoid a recently discovered bug in older versions.
carloruiz
approved these changes
Jun 11, 2024
fantapop
reviewed
Jun 17, 2024
@@ -6,6 +6,14 @@ description: |- | |||
Private endpoint connections allow customer applications to connect to a CockroachDB Cloud cluster without traversing the public internet. All application-database traffic remains within the cloud-provider network. | |||
--- | |||
|
|||
# _Warning_: Use of *private endpoints* requires >=v1.7.6 | |||
If you intend to use this provider to provision [private endpoints](https://github.com/cockroachdb/terraform-provider-cockroach/blob/main/docs/resources/private_endpoint_connection.md): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks!
Warnings about using latest provider for private endpoints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a warning to the README about the need to use a recent version of the provider for private endpoints to avoid a recently discovered bug in older versions.
Commit checklist
make generate
)