Enable copr builds for packit config

[dhodovsk]

We enabled copr builds in the packit config for you.

After merging this PR, you are just a few steps away from RPM builds being automatically triggered on your PR's.
It means, that you'll be able to try and play with your change, packaged as an RPM.

What are the next steps?

• Install Packit-as-a-Service github application in your repo
• In case you are first user, wait for account approval
• Enjoy the built RPMs!

For more info, please:

• check out the documentation: https://packit.dev/docs/
• contact @packit-service/the-packit-team

[martinpitt]

@dhodovsk : I'm terribly sorry that we have ignored this for so long 😿 . The thing is, this wouldn't really give us anything for this project in particular -- The copr build doesn't run any unit test, and the build itself is utterly trivial, basically just a single cp -r. The build happens as part of our downstream integration tests, which then also runs the actual browser tests.

However, I now learned about packit github upstream in general, e.g. here, and we are also enabling it officially for a project where it makes sense, and I also gave some feedback.

I still have it on my TODO list to use packit for releasing cockpit-ostree -- The bug that blocked us for 1½ years finally got resolved two weeks ago 🎉 , so it's time to try this again. That'll look totally different, thus I'll send a separate PR for that.

Thank you!

[martinpitt]

I changed my mind -- I forgot the already existing packit config file, and the simplifications are nice. Having this build will provide some initial validation for the packit release build, and we can still disable the pull_request trigger later. However, I changed it to run on rawhide only.

I enabled packit for the cockpit-project org and this repo, and force-push to trigger it.

[martinpitt]

@dhodovsk , @thrix : Hm, this failed badly:

env -u NODE_ENV npm install
npm ERR! code EACCES
npm ERR! syscall mkdir
npm ERR! path /.npm
npm ERR! errno -13
npm ERR! 
npm ERR! Your cache folder contains root-owned files, due to a bug in
npm ERR! previous versions of npm which has since been addressed.
npm ERR! 
npm ERR! To permanently fix this problem, please run:
npm ERR!   sudo chown -R 1021440000:0 "/.npm"

Seems the nodes you are running this on have some unclean builder home directory?

[thrix]

@martinpitt no idea, seems this is packit side (not testing farm) summoning @TomasTomecek @lachmanfrantisek

[lachmanfrantisek]

@thrix @martinpitt Thanks for letting us know. I've created an issue on our side (packit/sandcastle#85). I've proposed rebuilding the sandbox image. Looking at the proposed command, it can be related to the (random) user that run's the command in openshift.

[jpopelka]

packit/sandcastle#85 has been fixed and is currently deployed only in the staging instance of packit-service.
It will be deployed to production next week, i.e. Mon Dec 21

[martinpitt]

packit made a lot of progress in the recent weeks, and is settling down now. I finally managed to get the srpm builds to work in PR #172, so I guess it's finally time to enable this 😁

I rebased your PR to current master. We previously used to have packit builds for all Fedora releases, but indeed it is totally fine to only have rawhide -- the RPMs will work on any Fedora, they are noarch and are only very loosely coupled to cockpit.

[TomasTomecek]

one note, Dominika is no longer on our team (she's partying with OSCI now :)

[martinpitt]

@TomasTomecek : Right, but I still want to salvage her PR. It works great now, so I'll land this (once our own tests succeed). Thank you!

[martinpitt]

That's also all that we can do with packit on c-ostree. Running tests doesn't work as that needs a Fedora OSTree testbed, not a classic Fedora one. But we'll do the tests bits with cockpit and cockpit-podman.