Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Create template for CONTRIBUTING.md #118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mjang-cobalt
Copy link
Contributor

No description provided.

@mjang-cobalt mjang-cobalt self-assigned this Apr 22, 2022
@netlify
Copy link

netlify bot commented Apr 22, 2022

Deploy Preview for cobalt-docs ready!

Name Link
🔨 Latest commit e0a4940
🔍 Latest deploy log https://app.netlify.com/sites/cobalt-docs/deploys/6262c1fbd20b3b000826274b
😎 Deploy Preview https://deploy-preview-118--cobalt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

CONTRIBUTING.md Outdated Show resolved Hide resolved
EX-NO-TICKET_reason_for_change
```

We'll include a Continuous Integration job which reviews branch names.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergey-kruk-cobalt what's a good link for SOC2 compliance? I might add:

Suggested change
We'll include a Continuous Integration job which reviews branch names.
We'll include a Continuous Integration job which reviews branch names. This process helps us maintain [SOC2](replace_with_link_url) compliance.

@sergey-kruk-cobalt
Copy link

Contributing is usually much bigger and contains a lot of specifics. Now most of it in most of the projects is in README. But eventually I think all development-related info will be in CONTRIBUTING. Do you have access to https://github.com/cobalthq/cobalt-api/blob/main/CONTRIBUTING.md ?

@mjang-cobalt
Copy link
Contributor Author

Contributing is usually much bigger and contains a lot of specifics. Now most of it in most of the projects is in README. But eventually I think all development-related info will be in CONTRIBUTING. Do you have access to https://github.com/cobalthq/cobalt-api/blob/main/CONTRIBUTING.md ?

I do have access. I set up this PR as a MVC (and also as a demo of how we can comply with your RFC).

Rewriting the full CONTRIBUTING.md file is a larger task, and you're welcome to open a DOCS Jira for that.

If you're a Cobalt employee, include the group name acronym with the ticket, such as:

```
EX-NO-TICKET_reason_for_change

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think using kebab-case (at least in all documentation) would help consistency? I personally also like / dividers (which are also default for dependabot)

DOCS-12345_reason_for_change
```

Alternatively, if you do not have a Jira ticket, specify a branch name like

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general all branch naming rules need to reference one document (right now it't in confluence but it may move) so the basics are not repeated. And the reason to expand the section is only in case when you want to define specifics (what is the format, which PRs can have no tickets or if tickets are always required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants