LabHub: Use activate and configuration templates #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @nvzard, 1st Buildpython -m pytest |
|
Blocked until corobotestcase in plugins is implemented. |
|
Still relevant? |
nvzard
changed the title
nvzard
changed the title
Travis tests have failedHey @nvzard, |
gitmate-bot
added
size/S
area/config
difficulty/medium
importance/low
importance/medium
and removed
size/XS
labels
nvzard
changed the title
Travis tests have failedHey @nvzard, 1st Buildpython -m pytest |
Travis tests have failedHey @nvzard, 1st Buildpython -m pytest |
gitmate-bot
reviewed
Aug 3, 2018
plugins/labhub.py
Outdated
| assert gh is not None | ||
| except AssertionError: | ||
| except AssertionError: # pragma: no cover, for logging |
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: all.autopep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpammsf7vp/plugins/labhub.py
+++ b/tmp/tmpammsf7vp/plugins/labhub.py
@@ -52,7 +52,7 @@
try:
gh = github3.login(token=self.config['GH_TOKEN'])
assert gh is not None
- except AssertionError: # pragma: no cover, for logging
+ except AssertionError: # pragma: no cover, for logging
self.log.error('Cannot create github object, please check GH_TOKEN')
else:
self.GH3_ORG = gh.organization(self.config['GH_ORG_NAME'])
gitmate-bot
reviewed
Aug 3, 2018
plugins/labhub.py
Outdated
| self.IGH.write_repositories)} | ||
| except RuntimeError: | ||
| except RuntimeError: # pragma: no cover, for logging |
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: all.autopep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpammsf7vp/plugins/labhub.py
+++ b/tmp/tmpammsf7vp/plugins/labhub.py
@@ -71,7 +71,7 @@
filter(lambda x: (x.full_name.split('/')[0] ==
self.config['GH_ORG_NAME']),
self.IGH.write_repositories)}
- except RuntimeError: # pragma: no cover, for logging
+ except RuntimeError: # pragma: no cover, for logging
self.log.exception('Something went wrong in fetching github repos.')
else:
self.REPOS.update(self.gh_repos)
gitmate-bot
reviewed
Aug 3, 2018
plugins/labhub.py
Outdated
| assert gh is not None | ||
| except AssertionError: | ||
| except AssertionError: # pragma: no cover, for logging |
There was a problem hiding this comment.
E261 at least two spaces before inline comment
Origin: PycodestyleBear (E261), Section: all.autopep8.
Travis tests have failedHey @nvzard, 1st Buildcoala --non-interactive -Vpython -m pytest |
Travis tests have failedHey @nvzard, 1st Buildpython -m pytest |
Travis tests have failedHey @nvzard, 1st Buildpython -m pytest |
Travis tests have failedHey @nvzard, 1st Buildpython -m pytest |
jayvdb
requested changes
Aug 9, 2018
tests/isolated_testcase.py
Outdated
|
|
||
| def setUp(self, extra_config=None): | ||
| file_name = 'labhub.plug' | ||
| file_rename = 'hidden' |
There was a problem hiding this comment.
do class initialisation in setUpClass , including creating the hidden directory , and then remove the directory in tearDownClass.
nvzard
changed the title
nvzard
force-pushed
the
nvzard/activate
branch
from
2be746e
to
901c2f6
Compare
Travis tests have failedHey @nvzard, 1st Buildpython -m pytest |
nvzard
force-pushed
the
nvzard/activate
branch
2 times, most recently
from
277b189
to
b0e5fb3
Compare
jayvdb
changed the title
jayvdb
requested changes
Aug 10, 2018
tests/nevermind_test.py
Outdated
| "!hey nEverMINd", 'Command "hey" / "hey nEverMINd" not found.') | ||
| class NevermindTest(IsolatedTestCase): | ||
| def test_nevermind(self): | ||
| self.assertCommand("!nevermind", "I'm sorry :(") |
tests/nevermind_test.py
Outdated
| self.assertCommand("!hey nM", 'Command "hey" / "hey nM" not found.') | ||
| self.assertCommand("!nevermindxyz", 'Command "nevermindxyz" not found.') | ||
| self.assertCommand( | ||
| "!hey nEverMINd", 'Command "hey" / "hey nEverMINd" not found.') |
tests/ship_it_test.py
Outdated
| class ShipItTest(IsolatedTestCase): | ||
| def test_ship_it(self): | ||
| text = errbot.rendering.text() | ||
| self.assertCommand("!shipit", text.convert("![ship it!]()")) |
tests/spam_test.py
Outdated
|
|
||
| def test_spam_callback(self): | ||
| self.testbot.assertCommand('c'*1001, 'you\'re spamming') | ||
| self.testbot.assertCommand('\n\n'*11, 'you\'re spamming') | ||
| self.assertCommand('c'*1001, 'you\'re spamming') |
There was a problem hiding this comment.
add instance variable self.testbot = self
| @@ -43,30 +33,24 @@ def setUp(self): | |||
| } | |||
| } | |||
| } | |||
| self.testbot = TestBot(extra_plugin_dir='plugins', | |||
tests/ghetto_test.py
Outdated
| testbot.assertCommand("!ghetto ...", "Shiznit happens!") | ||
| @vcr.use_cassette('tests/cassettes/ghetto.yaml') | ||
| def test_ghetto(self): | ||
| self.assertCommand("!ghetto hi, whats up?", "hi, wassup?") |
tests/ghetto_test.py
Outdated
| with requests_mock.Mocker() as m: | ||
| m.register_uri('POST', 'http://www.gizoogle.net/textilizer.php', | ||
| text='test text which will not match with the regex') | ||
| self.assertCommand("!ghetto ...", "Shiznit happens!") |
jayvdb
reviewed
Aug 10, 2018
| @@ -65,7 +68,7 @@ def __init__(self, bot, name=None): | |||
| filter(lambda x: (x.full_name.split('/')[0] == | |||
| self.GH_ORG_NAME), | |||
| self.IGH.write_repositories)} | |||
| except RuntimeError: | |||
| except RuntimeError: # pragma: no cover, for logging | |||
There was a problem hiding this comment.
you should be able to use requests-mock to break IGitt so it gives a RuntimeError , but ... not critical ... this is OK for now
nvzard
force-pushed
the
nvzard/activate
branch
from
b0e5fb3
to
112fbb4
Compare
IsolatedTestCase prevents TestBot from loading LabHub as IGitt imports were delaying loading time for the bot due to repetitive attempts to send requests until an HTTP Client Error is raised. It was also not possible to patch the IGitt imports while testing these plugins as plugins in Errbot are loaded dynamically using yapsy plugin manager. So it is not possible to patch since the namespace is unknown. IsolatedTestCase is able to prevent loading of labhub plugin by renaming its `.plug` file. This prevents the TestBot from loading it.
nvzard
force-pushed
the
nvzard/activate
branch
from
112fbb4
to
e302640
Compare
jayvdb
approved these changes
Aug 10, 2018
|
ack e302640 |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__is executed at load time andand any issue in the plugin will lead
to it not showing up.
LifeCycle:
__init__->configured->enableAdapts to the
DefaultConfigMixinandmigrated to using configuration templates.
Closes #554
Closes #382