labhub: Adapt to the modified newcomer process #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `invite me` variation of invite command is removed. - "Hello world"s no longer trigger invites. - Newcomer invitation message is changed to show the modification in the newcomer process. Closes #476
meetmangukiya
force-pushed
the
meet/security/2
branch
from
fa10bae
to
a87b74e
Compare
jayvdb
requested changes
Dec 20, 2017
| @@ -1,9 +1 @@ | |||
| Welcome @{{ target }}! :tada: | |||
|
|
|||
| We've just sent you an invite via email. Please accept it before proceeding forward. | |||
There was a problem hiding this comment.
We still need an invite process via corobo, so this file and related code shouldnt be deleted.
|
unack a87b74e |
meetmangukiya
commented
Dec 20, 2017
| @@ -69,12 +69,11 @@ def test_hello_world_callback(self): | |||
| labhub = testbot.bot.plugin_manager.get_plugin_obj_by_name('LabHub') | |||
| labhub.TEAMS = teams | |||
| self.mock_team.is_member.return_value = False | |||
| testbot.assertCommand('hello, world', 'newcomer') | |||
| testbot.assertCommand('hello, world', 'newcomer', timeout=10000) | |||
There was a problem hiding this comment.
remove this timeout
|
Being done by @nvzard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invite mevariation of invite command is removed.newcomer process.
Closes #476
Reviewers Checklist
botcmdandre_botcmddecorators.