Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix time parameter of Speech Signals #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

d4ksn
Copy link

@d4ksn d4ksn commented Jul 27, 2016

Hello, I found the time statistics of the SpeedTracker is sometimes incorrect, with "This Time Audio: XX.Xs" being a very big number (actually it's a timestamp counting from 1970-01-01).
After tracing the code, I have found some issues regarding the time parameter of SpeechStartSignal/SpeechEndSignal, and fixed it by myself.

  1. I think SpeechEndSignal should be constructed with a time parameter relative to the audio time, just like in line 184 in this file. Otherwise, the time will be set to a system timestamp, which will cause the above issue.
  2. In the SpeechStartSignal constructor, the parameter is meant to be in millisecond (just like "cdata.getCollectTime()" and "speechLeader"). However, "startSpeechFrames" is counted in frame (which is "startSpeechTime"/10), so I have also changed this.

just some of my suggestions, I hope you would consider it, Thanks!

Fix minor bugs regarding to the time paramater of the SpeechStartSignal/SpeechEndSignal
Fix time paramater of the SpeechSignal
@nshmyrev
Copy link
Contributor

nshmyrev commented Aug 1, 2016

Thanks for the pull request. Overall, I'm not quite happy with the current design of the frontend, its so painful to track all those signals. We will probably refactor it altogether.

automenta pushed a commit to deepstupid/sphinx5 that referenced this pull request Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants