Adds FeatureExtractor and corresponding test class; #37
Conversation
| * | ||
| * @throws IOException if error occurred | ||
| */ | ||
| public FeatureExtractor(ConfigurationManager cm, String frontEndName, InputStream inputStream) |
There was a problem hiding this comment.
We do not expose configuration managers in high-level API, it is better to make all those details private.
Like I wrote in the original prototype, it is better to support different sample rates.
There was a problem hiding this comment.
Ok, but if I understand correctly, then the user can't choose the FrontEnd
configuration,
and it should always use the default xml configuration (default.config.xml)
(or we should hardcode the FrontEnd like in e.g. BandDetector)?
Thanks,
VJ
On Thu, Sep 10, 2015 at 1:57 PM, Nickolay V. Shmyrev <
[email protected]> wrote:
In sphinx4-core/src/main/java/edu/cmu/sphinx/api/FeatureExtractor.java
#37 (comment):
- private static final Logger logger = Logger
.getLogger("edu.cmu.sphinx.api.FeatureExtractor");
- /**
\* Constructs a FeatureExtractor.*\* @param cm\* the configuration manager\* @param frontEndName\* the name for the frontEnd to be used\* @param inputStream\* data stream*\* @throws IOException if error occurred*/- public FeatureExtractor(ConfigurationManager cm, String frontEndName, InputStream inputStream)
We do not expose configuration managers in high-level API, it is better to
make all those details private.Like I wrote in the original prototype, it is better to support different
sample rates.—
Reply to this email directly or view it on GitHub
https://github.com/cmusphinx/sphinx4/pull/37/files#r39151311.
There was a problem hiding this comment.
Yes, configuration must be hidden. Our high-level API hides default.config.xml in the same way.
There was a problem hiding this comment.
Hi,
I fixed the issues you mentioned, can you please review changes I made?
Thanks,
VJ
On Sat, Sep 12, 2015 at 11:08 AM, Nickolay V. Shmyrev <
[email protected]> wrote:
In sphinx4-core/src/main/java/edu/cmu/sphinx/api/FeatureExtractor.java
#37 (comment):
- private static final Logger logger = Logger
.getLogger("edu.cmu.sphinx.api.FeatureExtractor");
- /**
\* Constructs a FeatureExtractor.*\* @param cm\* the configuration manager\* @param frontEndName\* the name for the frontEnd to be used\* @param inputStream\* data stream*\* @throws IOException if error occurred*/- public FeatureExtractor(ConfigurationManager cm, String frontEndName, InputStream inputStream)
Yes, configuration must be hidden. Our high-level API hides
default.config.xml in the same way.—
Reply to this email directly or view it on GitHub
https://github.com/cmusphinx/sphinx4/pull/37/files#r39335845.
|
I made some changes, please review. |
| * the name for the frontEnd to be used | ||
| * @param inputStream | ||
| * data stream | ||
| * |
There was a problem hiding this comment.
The javadoc params don't match the actual parameters.
| /** | ||
| * Extracts all features from the supplied InputStream. | ||
| * | ||
| * @return float[][] when called first time, null otherwise |
There was a problem hiding this comment.
The return type was changed to a List. The javadoc should be updated.
No description provided.