Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly initialize bTag #45409

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Explicitly initialize bTag #45409

merged 1 commit into from
Jul 17, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

Fix maybe-uninitialized warning in UBSAN IBs:

  src/HLTriggerOffline/Higgs/plugins/MatchStruct.h:23:8: warning: '<unnamed>.MatchStruct::bTag' may be used uninitialized [-Wmaybe-uninitialized]
    23 | struct MatchStruct {
      |        ^~~~~~~~~~~
src/HLTriggerOffline/Higgs/plugins/HLTHiggsSubAnalysis.cc: In member function 'void HLTHiggsSubAnalysis::analyze(const edm::Event&, const edm::EventSetup&, EVTColContainer*)':
src/HLTriggerOffline/Higgs/plugins/HLTHiggsSubAnalysis.cc:408:76: note: '<anonymous>' declared here
  408 |             matches->push_back(MatchStruct(&cols->genJets->at(i), it->first));
      |                                                                            ^

PR validation:

Bot tests

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_UBSAN_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • HLTriggerOffline/Higgs (dqm)

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @mtosi this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

-1

Failed Tests: RelVals
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72752d/40301/summary.html
COMMIT: 7b92c1c
CMSSW: CMSSW_14_1_X_2024-07-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45409/40301/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

  • 29634.911A fatal system signal has occurred: segmentation violation

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72752d/40300/summary.html
COMMIT: 7b92c1c
CMSSW: CMSSW_14_1_UBSAN_X_2024-07-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45409/40300/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72752d/40300/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72752d/40300/git-merge-result

@iarspider
Copy link
Contributor Author

iarspider commented Jul 12, 2024

@cmsbuild ignore tests-rejected with ib-failure
See #41927

@iarspider
Copy link
Contributor Author

@cms-sw/dqm-l2 gentle ping

@tjavaid
Copy link

tjavaid commented Jul 16, 2024

@smuzaffar . The errors from the static check build, can be ignored here, right ?

@smuzaffar
Copy link
Contributor

please test

lets run the production architecture tests

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72752d/40428/summary.html
COMMIT: 7b92c1c
CMSSW: CMSSW_14_1_X_2024-07-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45409/40428/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345094
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345071
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jul 17, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6648f85 into cms-sw:master Jul 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants