Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new ZDCHitReconstructor and ZDCRecAlgo to work with QIE10 Digis and Updated ZDCRecHit #45407

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Added new ZDCHitReconstructor and ZDCRecAlgo to work with QIE10 Digis and Updated ZDCRecHit #45407

wants to merge 15 commits into from
+912 −3

Conversation

matt2275
Copy link
Contributor

@matt2275 matt2275 commented Jul 9, 2024 •
edited
Loading

PR description:

This is a draft pull request for adding new ZdcHitReconstuctor_Run3 and ZdcSimpleRecAlgo_Run3 to process QIE10 digis for the ZDC.

Additionally, ZDCRecHit was updated.

This update is dependent on fixes to the ZDC Geometry but a temporary fix is described here: https://github.com/matt2275/ZDCRecHit-Associated-Files

This update is being tested on CMSSW_14_1_0_pre2

PR validation:

No Validations tests have been run yet

Build Recipe

cmsrel CMSSW_14_1_0_pre5
cd CMSSW_14_1_0_pre5/src
cmsenv
git cms-merge-topic matt2275:Test_ZDCRecHit
scram b -j8

Note that this job will crash without a temporary fix to HcalZDCDetId which is referenced here

matt2275 and others added 10 commits June 6, 2024 14:38
@matt2275
Update ZDCRecHit.h
9191707 
Adding new variables to ZDC RecHit
@matt2275
Update ZDCRecHit.cc
105a40c 
Updating ZDC RecHit to include new features
@matt2275
Adding New ZDC Hit Reconstructor for Run3
5eb6cf3 
ZDC Hit Reconstructor that works with QIE10 digis
@matt2275
Cfi file for New ZDC Reconstructor
abd217d
@matt2275
Add files via upload
a7baad2
@matt2275
Adding New ZDC Rec Algo
c247507 
New ZDC Rec Algo to work with QIE10 Digis and Updated ZDC RecHit
@matt2275
Update classes_def.xml
a8f1963 
updated check_sum value of HCalZDCDetID
@matt2275
Revert "Update classes_def.xml"
5f540ca 
This reverts commit a8f1963.
@matt2275
Updated ZDC RecHit, RecHit Producer and Algo
8bd55c7 
updated ZDC rechit to include ratioSOIp1 which it  the ratio of energy of TS2/ TS3 assuming TS2 is the signal TS. Unused configurations inputs were removed from the ZDC RecHit Producer and New methods we added to RecHIt Algo. Reco1 is default, Reco2 matched L1 Trigger and Reco3 is for  RPD.
@matt2275
Updated ZDC RecHit Methods
b9e4878 
Changed name of New ZDCHitReconstructor to be consistent with other new files. Added local saturation flag setting in ZDCHitReconstructor_Run3.cc
@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Jul 9, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/40858

  • Found files with invalid states:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.h:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.cc:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@mandrenguyen
Copy link
Contributor

@matt2275 why not just fix the code checks?

@matt2275
Fixed Code Formating
c16f4b0 
Added cmsbuild code format fixes
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/40904

  • Found files with invalid states:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.h:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.cc:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @matt2275 for master.

It involves the following packages:

  • DataFormats/HcalRecHit (reconstruction)
  • RecoLocalCalo/HcalRecAlgos (reconstruction)
  • RecoLocalCalo/HcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @mariadalfonso, @missirol, @mmusich, @rchatter, @rovere, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

@matt2275 Please provide a recipe to test this code

@abdoulline
Copy link

This is just to explicitly include @igv4321

@hjbossi
Copy link
Contributor

hjbossi commented Jul 23, 2024

Hi All,

From conversations in mattermost, I believe the recipe @abdoulline shares above will work so that @mandrenguyen can test the PR.

Also, I agree as @mandrenguyen suggests that we cannot merge this until the geometry arrives (as we don't want to incorporate the workaround in the main framework). It would be good, however, to test/review as much of the code as possible before then to help prevent last minute rushing/mistakes. Towards that end, maybe @matt2275 you can resolve the additional comments remaining and we can proceed with the review from there?

Cheers,

Hannah

@hjbossi hjbossi mentioned this pull request Jul 23, 2024
Open
@matt2275
Small Code fixes
e1b878e 
removed redundant code and added fillDescription to ZdcHitReconstructor_Run3
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/41007

  • Found files with invalid states:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.h:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.cc:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@matt2275
Copy link
Contributor Author

I've updated to code to follow @mandrenguyen suggestions with a couple exceptions that have been addressed with individual comments

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/41010

  • Found files with invalid states:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.h:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.cc:

@cmsbuild
Copy link
Contributor

Pull request #45407 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

@matt2275
Update ZdcHitReconstructor_Run3.cc
ebe234c 
Updated ZDC Saturation Flag Setter to use range-based loop
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/41011

  • Found files with invalid states:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.h:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.cc:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/41012

  • Found files with invalid states:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.h:
    • RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.cc:

@cmsbuild
Copy link
Contributor

Pull request #45407 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandrenguyen mandrenguyen mandrenguyen left review comments

Assignees
No one assigned
Labels
changes-dataformats code-checks-approved orp-pending pending-signatures reconstruction-pending tests-pending
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matt2275 @cmsbuild @mandrenguyen @abdoulline @hjbossi