Make nTS loops configurable #45406
Make nTS loops configurable #45406
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45406/40857 |
|
A new Pull Request was created by @kaderci-johannes for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable nano |
|
please test |
|
@DryRun : can you please update your cmsDriver commands to use |
|
+1 Size: This PR adds an extra 16KB to repository
Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Local and global runs in HF require different number of time slices (3 for global and 6 for local). The sizes in the definitions of the digi tables already contain the variables but the for loops that fill those tables has hardcoded numbers instead of variables. This is a fix to make the nTS modification from the configuration script to work properly. This change was originally done locally by Alexi Mestvirishvili.
PR validation:
I ran the script in https://gitlab.cern.ch/cmshcal/hcalpfg/hcalnanoprod/-/blob/main/test/globalrun_cfg.py with default inputs and the output file had 3 time slices for HF, as expected. I also ran the script in https://gitlab.cern.ch/cmshcal/hcalpfg/hcalnanoprod/-/blob/main/test/localrun_cfg.py the same way. I edited the line: process.hcalDigiSortedTable.nTS_HF = cms.untracked.uint32(x) with x=6, 8 and 12. The output files from these instances were created with 6, 8 and 12 time slices for HF, respectively.