Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include branch split level in edmDumpEventContent --all #45405

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jul 8, 2024

PR description:

Adding branch split level to the output of edmDumpEventContent --all helped to figure out #43923 (comment) .

Resolves cms-sw/framework-team#946

PR validation:

The printout of edmDumpEventContent --all includes the added information

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

cms-bot internal usage

@makortel
Copy link
Contributor Author

makortel commented Jul 8, 2024

@cmsbuild, please test

@makortel
Copy link
Contributor Author

makortel commented Jul 8, 2024

@Dr15Jones please review

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • FWCore/PythonUtilities (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6dca65/40288/summary.html
COMMIT: 14a6ad6
CMSSW: CMSSW_14_1_X_2024-07-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45405/40288/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345068
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a61bc4f into cms-sw:master Jul 15, 2024
11 checks passed
@makortel makortel deleted the edmDumpEventContentSplitLevel branch July 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include branch split level in edmDumpEventContent --all
3 participants