Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutputModule test for TestProcessor #45404

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Added test to prove that TestProcessor can be used with OutputModules
  • Extended GetProductCheckerOutputModule to allow checking that the expected kept data products were actually available.

PR validation:

Code compiles and local running of new test worked.

Checks that the expected data products were kepts
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

cms-bot internal usage

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45404/40854

Code check has found code style and quality issues which could be resolved by applying following patch(s)

Test makes sure that OutputModules can also be tested.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/Modules (core)
  • FWCore/TestProcessor (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f0a13/40289/summary.html
COMMIT: b5ddf20
CMSSW: CMSSW_14_1_X_2024-07-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45404/40289/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345068
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Jul 9, 2024

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fb08f76 into cms-sw:master Jul 11, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the testProcessorOutputModule branch July 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants