Avoid releasing WaitingTask too early in case of exception in WaitingThreadPool

[makortel]

PR description:

Resolves #45194 . See #45194 (comment) for longer description.

Resolves cms-sw/framework-team#945

PR validation:

Unit tests run.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0_X (because #44901 was).

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45402/40852

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Concurrency/interface/WaitingThreadPool.h modified in PR(s): From cmssw 14 0 11 #45400

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• FWCore/Concurrency (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[makortel]

@Dr15Jones Could you cross check?

[makortel]

@cmsbuild, please abort

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45402/40853

[cmsbuild]

Pull request #45402 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35f043/40286/summary.html
COMMIT: 814bf9c
CMSSW: CMSSW_14_1_X_2024-07-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45402/40286/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-particleLevel_fromMiniAod had ERRORS

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345088
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345062
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

Unit test failure occurs in IBs and is reported in #44603 (comment)

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

@cmsbuild, ignore tests-rejected with ib-failure

[rappoccio]

+1