Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Catch VertexException in PATLeptonTimeLifeInfoProducer when fitVertex fails #45394

Conversation

kandrosov
Copy link
Contributor

PR description:

VertexException was occurring in PATLeptonTimeLifeInfoProducer when fitVertex failed. This PR fixes the issue by catching such exceptions in the fitVertex method and returning false.

PR validation:

Validated on a miniAOD file, on which the processing was originally failing due to the exception described above.

This PR is a backport of #45393 into 14_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2024

A new Pull Request was created by @kandrosov for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction, xpog)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor

hqucms commented Jul 6, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Jul 6, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4162b/40272/summary.html
COMMIT: 317d8e2
CMSSW: CMSSW_14_0_X_2024-07-06-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45394/40272/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 20 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342828
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342808
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 51 log files, 31 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.94 2.14 +84.5% 2.175 2.260
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.54 1.84 +92.9% 2.570 2.284
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.66 1.98 +84.6% 2.575 2.312
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.78 3.84 +76.7% 2.270 2.393
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.66 1.93 +90.1% 2.421 2.193
2500.012 1.761 1.761 0.000 ( +0.0% ) 5.30 3.00 +76.9% 2.343 2.189
2500.1 2.354 2.354 0.000 ( +0.0% ) 5.15 2.73 +89.0% 2.011 2.097
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.96 3.16 +88.6% 2.009 2.022
2500.21 1.286 1.286 0.000 ( +0.0% ) 4.25 2.28 +86.5% 2.239 1.995
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.86 2.15 +79.6% 2.246 2.093
2500.3 2.229 2.229 0.000 ( +0.0% ) 12.01 6.79 +76.8% 2.000 2.003
2500.301 2.833 2.833 0.000 ( +0.0% ) 10.76 5.69 +89.3% 1.986 1.992
2500.31 1.348 1.348 0.000 ( +0.0% ) 19.62 10.73 +82.8% 2.403 2.409
2500.311 1.757 1.757 0.000 ( +0.0% ) 15.66 8.41 +86.3% 2.472 2.486
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.53 0.97 +57.5% 1.711 1.716
2500.313 1.568 1.568 0.000 ( +0.0% ) 8.93 5.77 +54.7% 1.070 1.069
2500.314 1.236 1.236 0.000 ( +0.0% ) 15.00 8.13 +84.6% 2.257 2.307
2500.315 1.874 1.874 0.000 ( +0.0% ) 15.24 8.41 +81.3% 2.365 2.390
2500.316 3.342 3.342 0.000 ( +0.0% ) 2.10 1.14 +84.7% 2.298 2.030
2500.317 1.811 1.811 0.000 ( +0.0% ) 14.44 8.42 +71.5% 2.185 2.393
2500.318 4.136 4.136 0.000 ( +0.0% ) 5.70 3.16 +80.5% 2.249 2.395
2500.319 3.364 3.364 0.000 ( +0.0% ) 1.87 1.04 +80.9% 2.337 2.054
2500.4 2.374 2.374 0.000 ( +0.0% ) 11.46 6.29 +82.0% 1.863 1.956
2500.401 1.885 1.885 0.000 ( +0.0% ) 10.55 5.53 +90.8% 1.737 1.888
2500.402 2.950 2.950 0.000 ( +0.0% ) 10.25 5.72 +79.1% 1.727 1.948
2500.403 5.474 5.474 0.000 ( +0.0% ) 1.48 0.81 +83.0% 1.967 1.993
2500.404 2.860 2.860 0.000 ( +0.0% ) 10.42 5.73 +81.8% 1.794 1.940
2500.405 8.700 8.700 0.000 ( +0.0% ) 3.60 1.98 +81.9% 1.809 1.958
2500.406 5.491 5.491 0.000 ( +0.0% ) 1.35 0.77 +74.4% 2.014 2.007
2500.5 5.194 5.194 0.000 ( +0.0% ) 16.20 8.59 +88.6% 1.455 1.625
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.90 5.34 +85.3% 1.608 1.604

@hqucms
Copy link
Contributor

hqucms commented Jul 7, 2024

+1

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dfbad95 into cms-sw:CMSSW_14_0_X Jul 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants