Backport to 14_0_X of PR#45386 "Updated EcalUncalibRecHitTimingCCAlgo to correct for bias at high energies"

[jking79]

Backport of PR#45386 "Updated EcalUncalibRecHitTimingCCAlgo to correct for bias at high energies"

Added correction for MPGA slew issue to CC time reconstruction algorithm
Added useSlewCorrectionEB and useSlewCorrectionEE parameters to activate slew correction code
Tested and presented in ECAL DPG : https://indico.cern.ch/event/1433850/

[cmsbuild]

A new Pull Request was created by @jking79 for CMSSW_14_0_X.

It involves the following packages:

• RecoLocalCalo/EcalRecAlgos (reconstruction)
• RecoLocalCalo/EcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @missirol, @rchatter, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Updated EcalUncalibRecHitTimingCCAlgo to correct for bias at high energies #45386

[cmsbuild]

cms-bot internal usage

[thomreis]

type ecal

[thomreis]

backport of #45386

[thomreis]

please test

[thomreis]

Backport to check the effectiveness of the fix with a re-reco of early 2024 data where the high energy issue has been spotted.

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-038059/40262/summary.html
COMMIT: 15b297b
CMSSW: CMSSW_14_0_X_2024-07-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45388/40262/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 91 lines from the logs
• Reco comparison results: 65 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3342828
• DQMHistoTests: Total failures: 1219
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3341589
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[thomreis]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-038059/40291/summary.html
COMMIT: 15b297b
CMSSW: CMSSW_14_0_X_2024-07-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45388/40291/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 82 lines to the logs
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3342828
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3342808
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[antoniovilela]

-orp

• Until we discuss with PPD.

[antoniovilela]

@thomreis @cms-sw/ppd-l2 @mandrenguyen
Thomas, could you let us know if this is affecting any reconstruction sequence for data taking?

[thomreis]

Hi @antoniovilela no the CC timing is not in prompt reconstruction anymore since 14_0_9.
One has to activate the algorithm with the ecal_cctiming modifier.
Merging this should not affect data taking. It would allow special re-recos with customisations to check the fix.

[malbouis]

Hi @antoniovilela , our understanding from ECAL (@thomreis ) is that this CC timing only enters the reconstruction sequence via a proc modifier and therefore is not in standard reconstruction. On the other hand, they need these developments from this PR to be able to test the CC timing algorithm to have it included back in the standard reconstruction in 2025.
Thanks!

[antoniovilela]

Hi @antoniovilela no the CC timing is not in prompt reconstruction anymore since 14_0_9.
One has to activate the algorithm with the ecal_cctiming modifier.
Merging this should not affect data taking. It would allow special re-recos with customisations to check the fix.

Hi Thomas,
Thanks. We were just in doubt during the ORP meeting and wanted to confirm before merging.

[antoniovilela]

+1