Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SimBeamSpotHLLHC tags in Phase-2 MC GT and make Phase-2 workflows consume it #45387

Merged

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Jul 5, 2024

PR description:

In order to complete cms-AlCaDB/AlCaTools#95, and following the discussion in this AlCaDB CMSTalk post, in this PR I'm adding the new SimBeamSpotHLLHC tags to the Phase-2 MC GT, and I'm updating the Phase-2 relvals to consume it, similarly to what was done for Run1/2/3 MC GTs in #43242.

In order to consume these tags I have introduced a new DBrealisticHLLHC vertex smearing scenario which is configured through IOMC.EventVertexGenerators.VtxSmearedRealisticHLLHC_cfi to use the HLLHCEvtVtxGenerator and read the parameters from the GT.
The GenSim steps of the Phase2 workflows are now updated to used this scenario by default.

Since only one Phase-2 GT is currently available in autoCond, the 14 TeV tag is added by default to the GT (see links below), while the 13 TeV tag is added to a new autoCondBSHLLHC13TeV modifier, which creates new symbolic phase2 GTs with an additional _13TeV in the name, that will be consumed where the HLLHC scenario used to be used.

New tags and GTs:

PR validation:

Run:

# For HLLHC scenario
runTheMatrix.py -l 29661.0 --ibeos -j 8
# For HLLHC14TeV scenario
runTheMatrix.py --what upgrade -l 20027.0 --ibeos -j 8

and verified that:

  • they finish successfully
  • the GS step of the workflows is configured with the correct --conditions and --beamspot values

Backport:

Not a backport, no backport needed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45387/40837

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)

@AdrianoDee, @antoniovilela, @civanch, @cmsbuild, @consuegs, @davidlange6, @fabiocos, @kskovpen, @mdhildreth, @miquork, @perrotta, @rappoccio, @saumyaphor4252, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @grzanka, @makortel, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @sameasy, @slomeo, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2024

please test
(let retry, even if there are still quite several errors in the master IBs)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a961fa/40274/summary.html
COMMIT: c888742
CMSSW: CMSSW_14_1_X_2024-07-07-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45387/40274/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 21 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3246793
  • DQMHistoTests: Total failures: 853
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3245920
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 199 log files, 163 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2024

+alca

@srimanob
Copy link
Contributor

srimanob commented Jul 7, 2024

+Upgrade

@civanch
Copy link
Contributor

civanch commented Jul 7, 2024

+1

@AdrianoDee
Copy link
Contributor

+pdmv

@francescobrivio
Copy link
Contributor Author

@cms-sw/orp-l2 could you please review and sign this PR (which is currently only missing orp+operations signatures) whenever you have some time?
Many thanks!
Francesco

For the record: differences in 12834.7 are the usual issue tracked in #39803

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit e232a9b into cms-sw:master Jul 9, 2024
11 checks passed
@francescobrivio francescobrivio deleted the alca-consume_simBeamSpotHLLHC branch July 11, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants