-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Phase-2 Geometry D86, D88, D91, D92, D93, D94, D97 #45370
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45370/40803
|
A new Pull Request was created by @srimanob for master. It involves the following packages:
@AdrianoDee, @Dr15Jones, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kskovpen, @makortel, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8685c7/40204/summary.html
Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
@srimanob Please do not remove D94 which is the only one using HFNose |
-1 |
Hi @bsunanda It would be great if you can provide the timeline of your comment in #43251 (comment) ? You mentioned that "Also we need to keep a scenario with C20. If D94 is to be deleted we have to create one with C20 as D111". I also mention in the description of this PR that we need that, I did not ignore the request, but no timeline provided on geometry side. Is it straightforward to create new geometry with C20? The goal of the cleanup is to completely remove geometry with I14 and I15. Thx. |
I make a draft PR of D115 which is D110 with C20 (C18+HFNose) |
Please do not make that one. I am making one myself. I am committing it now
…________________________________
From: Phat Srimanobhas ***@***.***>
Sent: 04 July 2024 16:01
To: cms-sw/cmssw ***@***.***>
Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***>
Subject: Re: [cms-sw/cmssw] Clean up Phase-2 Geometry D86, D88, D91, D92, D93, D94, D97 (PR #45370)
I make a draft PR<#45372> of D115 which is D110 with C20 (C18+HFNose)
—
Reply to this email directly, view it on GitHub<#45370 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOQXNYNIRYSWG6JZNYDZKUQA7AVCNFSM6AAAAABKKBBSA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYGY2DMNJZHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
+geometry |
hold We wait a bit until sample in 14_0 is available |
Pull request has been put on hold by @srimanob |
Pull request #45370 was updated. @AdrianoDee, @Dr15Jones, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kskovpen, @makortel, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
PR description:
This PR follows the issue #43251 to clean up all geometries with I14 and I15. With this PR, T24, T25, T30, I14, I15, O8 become unused geometries. They are in the list of obsolete subdetectors.
We will need a follow up PR, to introduce new geometry with HFNose to replace D94.
FYI @cms-sw/mtd-dpg-l2 @cms-sw/geometry-l2 @cms-sw/trk-dpg-l2 @emiglior @cms-sw/l1-l2
PR validation:
Try to dump D95, D110 config. runTheMatrix gives the proper config files.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No need of backport.