Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2024 L1T modifier & modifiers for changing BMTF quality calculation #45352

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

aloeliger
Copy link
Contributor

PR description:

This PR adds an Era based modifier to the new BMTF quality calculation introduced by #44432, to allow for use of the old versus new quality calculation in the planned upcoming re-reco + MC campaign. The default is to use the old calculation and for Run3_2024 Eras and beyond to use the new calculation.

As a note, this does introduce a modifier file I have created personally, I don't know if there is a standard for who can create these or when they should be made, and it is introduced to the Run3_2024 era.

@slaurila @eyigitba: FYI

PR validation:

All code compiles and has had formatting applied. The settings+flag has been tested in L1 re-emulation under different eras to trigger the correct quality calculation.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport and is not expected to be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45352/40771

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • L1Trigger/L1TMuonBarrel (l1)

@aloeliger, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @rappoccio can you please review it and eventually sign? Thanks.
@AnnikaStein, @JanFSchulte, @Martin-Grunewald, @dinyar, @eyigitba, @fabiocos, @makortel, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b955f/40177/summary.html
COMMIT: bc19415
CMSSW: CMSSW_14_1_X_2024-07-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45352/40177/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor Author

+l1

@perrotta
Copy link
Contributor

urgent
(backport needed for 2024 MC production)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit f7de58a into cms-sw:master Jul 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants