Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 Scouting Online Selection modules #45350

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

Mmiglio
Copy link
Contributor

@Mmiglio Mmiglio commented Jul 1, 2024

PR description:

This PR introduces the modules used for the L1 Scouting Online selection, which will complement the "Zero bias" stream.
The selection stream was discussed during L1 Trigger DPG meetings (e.g. link)

Related to this PR, a new category is introduced with cms-sw/cms-bot#2276.

PR validation:

The PR has been validate using files collected in the "Zero Bias" stream, e.g.

cmsRun test/L1ScoutingSelector.py inFile=file:root://xrootd-cms.infn.it///store/data/Run2024F/L1Scouting/L1SCOUT/v1/000/382/580/00000/00c66a36-4a65-4b2a-a637-0b02629cb1da.root numOrbits=100 outFile=/tmp/dump.root

In parallel, it was successfully tested in the Scouting system at P5.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We would like this PR to be backported in a data-taking release (14_0_X) in order to collect data from pp collisions during 2024.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45350/40769

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

A new Pull Request was created by @Mmiglio for master.

It involves the following packages:

  • EventFilter/L1ScoutingRawToDigi (daq)
  • L1TriggerScouting/OnlineProcessing (****)

The following packages do not have a category, yet:

L1TriggerScouting/OnlineProcessing
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor

smorovic commented Jul 1, 2024

@cmsbuild please test

@smorovic
Copy link
Contributor

smorovic commented Jul 1, 2024

cms-sw/cms-bot#2278 adds new package to cms-bot

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-329d42/40169/summary.html
COMMIT: 936c886
CMSSW: CMSSW_14_1_X_2024-07-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45350/40169/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345062
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor

smorovic commented Jul 1, 2024

+daq

@Mmiglio
Copy link
Contributor Author

Mmiglio commented Jul 8, 2024

cms-sw/cms-bot#2276 assigns this new package to l1t category. Can this PR be updated as well?
adding @aloeliger as discussed in last week's L1 offline software meeting.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

Pull request #45350 was updated. @aloeliger, @epalencia can you please check and sign again.

@epalencia
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8b87f54 into cms-sw:master Jul 11, 2024
11 checks passed
@Mmiglio Mmiglio deleted the OnlineSelection branch July 15, 2024 07:09
@Mmiglio Mmiglio restored the OnlineSelection branch July 15, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants