slha-multiple-reinitializations

[smrenna]

…iple reinits

[cmsbuild]

A new Pull Request was created by @smrenna for branch cms/240.

@iarspider, @aandvalenzuela, @smuzaffar, @cmsbuild can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smrenna]

Backporting of changes to SLHA interface that allows for multiple init calls to pythia (thereby changing the min/max values for resonances).

[menglu21]

@cmsbuild please test

[menglu21]

@smuzaffar is it supposed to test with a specific release

[sarafiorendi]

hi, a kind request to try to include this PR as soon as possible, it is needed for the production of samples for analyses which are already pre-approved. thanks!

[menglu21]

@cmsbuild please test

[menglu21]

@cmsbuild please test for CMSSW_10_6_X/slc7_amd64_gcc700

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eec6f6/39894/summary.html
COMMIT: e42d7e1
CMSSW: CMSSW_10_6_X_2024-06-09-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/pythia8/32/39894/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_MpsWorkFlow had ERRORS

Comparison Summary

Summary:

• You potentially removed 19 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215350
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 144 log files, 103 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[mmasciov]

A gentle ping.
Let me stress that this PR should be considered very urgent, since the lack of this fix is holding an increasing number of MC requests, for an increasing number of analyses.
Thanks!

[fwyzard]

Just a suggestion, but maybe improving the title and the description of the PR could help.

[fwyzard]

And also fixing the tests... is test_MpsWorkFlow relevant ?

[menglu21]

Just a suggestion, but maybe improving the title and the description of the PR could help.

Hi @fwyzard , the purpose of this PR is
"applied patch to handle min/max values of resonance masses after multiple reinits.
Explicit checks are made to guarantee that the minimum value sampled for a resonance mass
is below the nominal mass. This is relevant when the slha information is updated in Pythia and
an existing pythia instance is re-initialized." which is in PR #31. Is it necessary to change the title, if yes, @smrenna please modify the title.

as for the test, tbh I'm not sure whether the release is needed. The error https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eec6f6/39894/unitTests/src/Alignment/MillePedeAlignmentAlgorithm/test/test_MpsWorkFlow/testing.log should be irrelevant to the modification to me

[menglu21]

urgent

[menglu21]

let's try another test, if the error is still there but not related to the change, I suggest we can merge this PR

[menglu21]

@cmsbuild please test

[menglu21]

Hi @smuzaffar @fwyzard there is error "IOError: [Errno 2] No such file or directory: 'src/Alignment/MillePedeAlignmentAlgorithm/templates/universalConfigTemplate.py'" in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eec6f6/39894/unitTests/src/Alignment/MillePedeAlignmentAlgorithm/test/test_MpsWorkFlow/testing.log, but I don't think the pythia8 change will cause this error. do you know how this happened. Since this PR is needed urgently by the analysis, how should we proceed

[smuzaffar]

correct , test_MpsWorkFlow failure is not related to this change. This is because 10.6.X is missing cms-sw/cmssw@6bd5d30 fix

[smuzaffar]

+externals

these changes are backported from python 8.311 release https://gitlab.com/Pythia8/releases/-/commit/001b35e1f9ba95cb9dc5e212635a4fdadc614b21

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next cms/240 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@cmsbuild please test

please test by default runs tests for development CMSSW release cycle i.e. 14.1.X at this time. This PR should be tested for CMSSW_10_6_X. so using please for for CMSSW_10_6_X is the correct way to test it

[smuzaffar]

I am merging it and opening a cmsdist PR to include it for 10.6.X