Don't build C source if running on PYPY #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid building C optimised version if running on PYPY and use the plain python implementation 1- pypy have a penalty cost at the python to C interface 2- I found this memory leak: pypy/pypy#5100 As implementation I took inspiration from msgpack https://github.com/msgpack/msgpack-python/blob/main/setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid building C optimised version if running on PYPY and use the plain python implementation
As implementation I took inspiration from msgpack https://github.com/msgpack/msgpack-python/blob/main/setup.py
Alternative is to use
import cobs.cobs._cobs_py as cobsinstead offrom cobs import cobsbut this move the burden to the userspace and it is pretty uglyThanks,
Luca