-Crash fix: Bots getting mail with items where the item was already g…

…one.
cmangos · Sep 15, 2024 · e3c9941 · e3c9941
1 parent f7b12b3
commit e3c9941
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/playerbot/strategy/actions/MailAction.cpp b/playerbot/strategy/actions/MailAction.cpp
@@ -132,15 +132,18 @@ class TakeMailProcessor : public MailProcessor
 #endif
                 Item* item = bot->GetMItem(*i);
 
-                if (event.getSource() == "rpg action")
+                if (item)
                 {
-                    items.push_back(ChatHelper::formatItem(item, item->GetCount()));
-                }
-                else
-                {
-                    std::ostringstream out;
-                    out << mail->subject << ", " << ChatHelper::formatItem(item) << "|cff00ff00 processed";
-                    ai->TellPlayer(requester, out.str(), PlayerbotSecurityLevel::PLAYERBOT_SECURITY_ALLOW_ALL, false);
+                    if (event.getSource() == "rpg action")
+                    {
+                        items.push_back(ChatHelper::formatItem(item, item->GetCount()));
+                    }
+                    else
+                    {
+                        std::ostringstream out;
+                        out << mail->subject << ", " << ChatHelper::formatItem(item) << "|cff00ff00 processed";
+                        ai->TellPlayer(requester, out.str(), PlayerbotSecurityLevel::PLAYERBOT_SECURITY_ALLOW_ALL, false);
+                    }
                 }
 
                 bot->GetSession()->HandleMailTakeItem(packet);