Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): hex recognition the template type #212

Closed
wants to merge 2 commits into from

Conversation

yuxialuozi
Copy link
Contributor

What type of PR is this?

fix

What this PR does / why we need it (en: English/zh: Chinese):

en: Server specifies hex and cannot determine the template type
zh: server 指定 hex 参数时无法确定模板类型

Which issue(s) this PR fixes:

Related to #207

@yuxialuozi yuxialuozi changed the title fix(server): hex recognitionthe template type fix(server): hex recognition the template type Aug 12, 2024
@StellarisW
Copy link
Member

Thanks for the contribution,
but hex is only valid for server type "RPC", such cwgo server --type RPC --idl idl/hello.thrift --service p.s.m --hex
thus it's wrong to add arg in server type "HTTP", please check the new logic is whether correct and test it by generating code

@li-jin-gou
Copy link
Member

li-jin-gou commented Aug 12, 2024

添加参数并不是一个最优解法,它是代码实现最简单的,但是并不方便,我们不会采纳

@li-jin-gou li-jin-gou closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants