chore(ui): migrate DateTimePicker to TypeScript #640
+3,132
−511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c946c0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
ArtieReus
added
the
ui-components
guoda-puidokaite
added
package
guoda-puidokaite
requested changes
Nov 27, 2024
packages/ui-components/src/components/DateTimePicker/DateTimePicker.component.tsx
Outdated
Show resolved
Hide resolved
packages/ui-components/src/components/DateTimePicker/DateTimePicker.component.tsx
Outdated
Show resolved
Hide resolved
packages/ui-components/src/components/DateTimePicker/DateTimePicker.component.tsx
Outdated
Show resolved
Hide resolved
packages/ui-components/src/components/DateTimePicker/DateTimePicker.component.tsx
Outdated
Show resolved
Hide resolved
packages/ui-components/src/components/DateTimePicker/DateTimePicker.component.tsx
Show resolved
Hide resolved
packages/ui-components/src/components/DateTimePicker/DateTimePicker.component.tsx
Show resolved
Hide resolved
packages/ui-components/src/components/DateTimePicker/DateTimePicker.component.tsx
Show resolved
Hide resolved
packages/ui-components/src/components/DateTimePicker/DateTimePicker.component.tsx
Show resolved
Hide resolved
added 4 commits
November 27, 2024 11:48
guoda-puidokaite
requested changes
Nov 28, 2024
Comment on lines
+145
to
+147
| const fpRef = useRef<HTMLInputElement>(null) // the dom node flatpickr instance will be bound to | ||
| const flatpickrInstanceRef = useRef<flatpickr.Instance | null>(null) // The actual flatpickr instance | ||
| const calendarTargetRef = useRef(null) // The DOM node the flatpickr calendar should be rendered to |
There was a problem hiding this comment.
(Blocking)
We need types everywhere here:
Suggested change
| const fpRef = useRef<HTMLInputElement>(null) // the dom node flatpickr instance will be bound to | |
| const flatpickrInstanceRef = useRef<flatpickr.Instance | null>(null) // The actual flatpickr instance | |
| const calendarTargetRef = useRef(null) // The DOM node the flatpickr calendar should be rendered to | |
| const fpRef = useRef<HTMLInputElement | null>(null) // The DOM node flatpickr instance will be bound to | |
| const flatpickrInstanceRef = useRef<flatpickr.Instance | null>(null) // The actual flatpickr instance | |
| const calendarTargetRef = useRef<HTMLDivElement | null>(null) // The DOM node the flatpickr calendar should be rendered to |
| //if (instance) { | ||
| instance?.destroy() | ||
| setTheDate({}) | ||
| flatpickrInstanceRef.current = null // Not sure if this is actually necessary? |
There was a problem hiding this comment.
(Non-Blocking Suggestion)
I think it is, comment can be removed.
|
|
||
| const destroyFlatpickrInstance = () => { | ||
| const instance = flatpickrInstanceRef.current | ||
| //if (instance) { |
There was a problem hiding this comment.
(Blocking)
Since this commented out code was introduced in this PR, please remove for cleaner code 🙏
| instance?.destroy() | ||
| setTheDate({}) | ||
| flatpickrInstanceRef.current = null // Not sure if this is actually necessary? | ||
| //} |
There was a problem hiding this comment.
(Blocking)
Since this commented out code was introduced in this PR, please remove for cleaner code 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
migrate DateTimePicker to TypeScript
Changes Made
Related Issues
Testing Instructions
npm inpm run storybookChecklist