-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): fix Grid stories after Typescript migration #598
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a good from my side you can transfer it to a normal PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ebd3fcb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Please make a changeset |
Summary
After merging the
Grid
,GridColumn
andGridRow
migration PR, I found that Storybook had a few unintended styling changes (as below). This PR fixes these documentation changes.Issues Found: Old Storybook on left, after migration on right:
Changes Made
Fixed Storybook, as was.
Related Issues
Screenshots (if applicable)
Testing Instructions
Grid
,GridColumn
andGridRow
StorybookChecklist