Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): fix Grid stories after Typescript migration #598

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

guoda-puidokaite
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite commented Nov 8, 2024

Summary

After merging the Grid, GridColumn and GridRow migration PR, I found that Storybook had a few unintended styling changes (as below). This PR fixes these documentation changes.

Issues Found: Old Storybook on left, after migration on right:
Screenshot 2024-11-08 at 10 30 27
Screenshot 2024-11-08 at 10 30 51
Screenshot 2024-11-08 at 10 31 03
Screenshot 2024-11-08 at 10 31 41
Screenshot 2024-11-08 at 10 32 01

Changes Made

Fixed Storybook, as was.

Related Issues

Screenshots (if applicable)

Testing Instructions

  • Check Grid, GridColumn and GridRow Storybook

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@guoda-puidokaite guoda-puidokaite added documentation Improvements or additions to documentation package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library labels Nov 8, 2024
@guoda-puidokaite guoda-puidokaite self-assigned this Nov 8, 2024
Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: b3f9c42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-08 14:40 UTC

@guoda-puidokaite guoda-puidokaite marked this pull request as ready for review November 8, 2024 10:18
@guoda-puidokaite guoda-puidokaite linked an issue Nov 8, 2024 that may be closed by this pull request
6 tasks
@guoda-puidokaite guoda-puidokaite marked this pull request as draft November 8, 2024 10:20
barsukov
barsukov previously approved these changes Nov 8, 2024
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a good from my side you can transfer it to a normal PR

andypf
andypf previously approved these changes Nov 8, 2024
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guoda-puidokaite guoda-puidokaite dismissed stale reviews from barsukov and andypf via ebd3fcb November 8, 2024 11:36
@guoda-puidokaite guoda-puidokaite marked this pull request as ready for review November 8, 2024 11:37
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@barsukov
Copy link
Contributor

barsukov commented Nov 8, 2024

Please make a changeset

@andypf andypf merged commit 25255c8 into main Nov 8, 2024
15 checks passed
@andypf andypf deleted the guoda-fix-grid-story branch November 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK](ui): Migrate Grid(All related) component to TypeScript
3 participants