chore(ui): migrate ComboBox component to typescript

[gjaskiewicz]

Summary

Migrate combobox to TypeScript

Changes Made

• Migrate Combobox to TypeScript
• Migrate ComboboxOption to TypeScript

Related Issues

• Issue 1: [link to issue]

Testing Instructions

1. npm i
2. npm run storybook

Checklist

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• I have made corresponding changes to the documentation (if applicable).
• My changes generate no new warnings or errors.

[github-actions]

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-18 13:11 UTC

[barsukov]

You delete everything where is the changes? :) I mean if it is a draft or not finished please close the PR

[gjaskiewicz]

@barsukov @guoda-puidokaite can you take a look?

[andypf]

LGTM

[barsukov]

Few comments from my side

[changeset-bot]

🦋 Changeset detected

Latest commit: c76db3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudoperators/juno-ui-components	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[guoda-puidokaite]

A few things from my side

[guoda-puidokaite]

(Blocking)

Prettier issue in pipeline

[barsukov]

Please also change index file, to return deprecated combobox cause it is still use a portal provider until we done with all related portal provider messages @guoda-puidokaite could you also check the warnings in console if it would be introduce here?

[guoda-puidokaite]

🙏

The request has been addressed.

[guoda-puidokaite]

(Blocking)

Discrepancies in Storybook (currently live on left, PR on right):

1. ComboBoxOption: children missing in props

2. ComboBox: Breaking type change? The updated type for helptext, errortext and successtext is more restrictive than ReactNode. Could these be breaking changes?

3. ComboBox: Are these function controls correct? Doesn't look right, but not sure. We didn't have any controls in the past. 🤷‍♀️

Before requesting another review, please double check that the old Storybook has no regressions. 🙏 It's difficult, as there's so many props in this one! But we can do it with few eyes on it. 👀

[andypf]

@gjaskiewicz Kindly address the issues identified by Guoda. It seems there are some regressions that need attention.

[gjaskiewicz]

(Blocking)

Discrepancies in Storybook (currently live on left, PR on right):

1. ComboBoxOption: children missing in props

2. `ComboBox`: Breaking type change? The updated type for `helptext`, `errortext` and `successtext` is more restrictive than `ReactNode`. Could these be breaking changes?

3. ComboBox: Are these function controls correct? Doesn't look right, but not sure. We didn't have any controls in the past. 🤷‍♀️

Before requesting another review, please double check that the old Storybook has no regressions. 🙏 It's difficult, as there's so many props in this one! But we can do it with few eyes on it. 👀

Checked storybook options one-by-one. Should be fine now.

[guoda-puidokaite]

Looks great, Thank You for the fixes! 🚀💪

Love that you added some descriptions to the docs for ComboBoxOptions, just made an observation on how we might be able to improve them. Change not required. 🙏

@andypf @barsukov, since this PR has so many comments, would be lovely if both of you could review too.

[barsukov]

LGTM