Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): migrate Checkbox components to Typescript #310

Merged
merged 6 commits into from
Sep 10, 2024
Merged

chore(ui): migrate Checkbox components to Typescript #310

merged 6 commits into from
Sep 10, 2024

Conversation

gjaskiewicz
Copy link
Contributor

Summary

Migrated Checkbox component to TS

Changes Made

  • Migrated Checkbox component to TS
  • Moved JS Checkbox context to separate file, but deleted CheckboxGroup
  • Removed Checkboxed from Form storybook (updated ticket)

Related Issues

Testing Instructions

  1. npm i
  2. turbo test

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@gjaskiewicz gjaskiewicz requested review from franzheidl and a team as code owners September 6, 2024 08:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c6003a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-10 06:55 UTC

barsukov
barsukov requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

packages/ui-components/src/components/Checkbox/Checkbox.component.tsx Show resolved Hide resolved
packages/ui-components/src/components/CheckboxGroup/CheckboxGroup.component.tsx Show resolved Hide resolved
@barsukov barsukov requested review from barsukov and removed request for barsukov September 9, 2024 13:53
barsukov
barsukov previously approved these changes Sep 9, 2024
View reviewed changes
@barsukov barsukov enabled auto-merge (squash) September 9, 2024 14:03
@barsukov barsukov merged commit d1c14e2 into main Sep 10, 2024
14 checks passed
@barsukov barsukov deleted the chore/gjaskiewicz-ts-checkboxes-components branch September 10, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barsukov barsukov barsukov approved these changes

@edda edda edda approved these changes

@franzheidl franzheidl Awaiting requested review from franzheidl franzheidl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjaskiewicz @edda @barsukov