Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): migrate radio- and withDeprecationWarning components to TypeScript #296

Merged
merged 15 commits into from
Sep 5, 2024
Merged

chore(ui): migrate radio- and withDeprecationWarning components to TypeScript #296

merged 15 commits into from
Sep 5, 2024

Conversation

gjaskiewicz
Copy link
Contributor

@gjaskiewicz gjaskiewicz commented Sep 3, 2024 •
edited
Loading

Summary

Migrate radio- components to TypeScript

Changes Made

  • Migrate Radio component to TS
  • Migrate RadioRow component to TS
  • Migrate RadioGroup component to TS
  • Migrate withDeprecationWarning component to TS

Related Issues

Testing Instructions

  1. npm i
  2. turbo test

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@gjaskiewicz gjaskiewicz requested review from franzheidl and a team as code owners September 3, 2024 14:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a1350ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-05 14:19 UTC

@gjaskiewicz gjaskiewicz changed the title chore(ui): migrate radio- components to TypeScript chore(ui): migrate radio- and withDeprecationWarning components to TypeScript Sep 3, 2024
barsukov
barsukov requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few little comments

packages/ui-components/src/components/Form/Form.stories.js Outdated Show resolved Hide resolved
packages/ui-components/src/components/IconTs/Icon.component.tsx Show resolved Hide resolved
barsukov
barsukov requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omit

@barsukov barsukov merged commit 502ec8f into main Sep 5, 2024
13 checks passed
@barsukov barsukov deleted the chore/gjaskiewicz-ts-radio-components branch September 5, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barsukov barsukov barsukov approved these changes

@franzheidl franzheidl Awaiting requested review from franzheidl franzheidl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjaskiewicz @barsukov