Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add FormattedText component #284

Merged
merged 14 commits into from
Sep 18, 2024
Merged

feat(ui): add FormattedText component #284

merged 14 commits into from
Sep 18, 2024

Conversation

barsukov
Copy link
Contributor

@barsukov barsukov commented Aug 29, 2024 •
edited by MartinS-git
Loading

Summary

Update: The package has been removed. All formatting is now handled within 'formatted-text.scss'

Typography and css

  • FormattedText

Screenshots (if applicable)

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@barsukov barsukov requested review from franzheidl and a team as code owners August 29, 2024 14:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a81dc1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-18 14:47 UTC

@barsukov barsukov added the enhancement New feature or request label Aug 29, 2024
@barsukov barsukov mentioned this pull request Aug 29, 2024
Closed
@edda edda marked this pull request as draft September 6, 2024 10:15
barsukov
barsukov commented Sep 16, 2024
View reviewed changes
Copy link
Contributor Author

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes...

packages/ui-components/src/components/FormattedText/formatted-text.scss Outdated Show resolved Hide resolved
packages/ui-components/src/index.js Outdated Show resolved Hide resolved
@MartinS-git MartinS-git marked this pull request as ready for review September 16, 2024 13:03
edda
edda requested changes Sep 16, 2024
View reviewed changes
.changeset/fast-pandas-behave.md Outdated Show resolved Hide resolved
.changeset/gentle-carrots-talk.md Outdated Show resolved Hide resolved
@barsukov barsukov requested a review from edda September 18, 2024 11:43
@barsukov barsukov enabled auto-merge (squash) September 18, 2024 11:44
TilmanHaupt
TilmanHaupt approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@TilmanHaupt TilmanHaupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@barsukov barsukov merged commit 8c3d471 into main Sep 18, 2024
23 checks passed
@barsukov barsukov deleted the wowa-marting-typography branch September 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TilmanHaupt TilmanHaupt TilmanHaupt approved these changes

@edda edda edda approved these changes

@franzheidl franzheidl Awaiting requested review from franzheidl franzheidl is a code owner

Assignees

@MartinS-git MartinS-git

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barsukov @edda @TilmanHaupt @MartinS-git