chore(doc): add setup section #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drochow
reviewed
Jul 12, 2024
| @@ -40,7 +40,23 @@ For a detailed understanding of the system's architecture and design, refer to t | |||
|
|
|||
| ## Requirements and Setup | |||
|
|
|||
There was a problem hiding this comment.
I like the description, but I think the default way should be using the Makefile no?
Also I think we need to add a couple more information such as environment variables etc.
WDYT?
There was a problem hiding this comment.
You're right. I'll add this
drochow
requested changes
Jul 15, 2024
Comment on lines
+60
to
+61
|
|
||
| DOCKER_CREDENTIAL_STORE=docker-credential-desktop |
There was a problem hiding this comment.
I think this is not a self-explanatory env var, lets add some context with a comment?
|
|
||
| LOG_PRETTY_PRINT=true | ||
|
|
||
| LOCAL_TEST_DB=true |
There was a problem hiding this comment.
I think this is not a self-explanatory env var
|
|
||
| LOCAL_TEST_DB=true | ||
|
|
||
| SEED_MODE=false |
There was a problem hiding this comment.
I think this is not a self-explanatory env var
drochow
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.