feat(issueMatch): Fix issueMatch creation by adding CreatedBy field to OnComponentVersionAttachmentToIssue event #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onentVersionAttachmentToIssue event
BlakePatterson
requested review from
drochow,
MR2011 and
dorneanu
as code owners
MR2011
reviewed
Nov 27, 2024
| @@ -170,6 +171,9 @@ func createIssueMatches( | |||
|
|
|||
| // Create new issue match | |||
| issue_match := &entity.IssueMatch{ | |||
| Metadata: entity.Metadata{ | |||
| CreatedBy: 1, | |||
| }, | |||
There was a problem hiding this comment.
Don't we want to use the common.GetCurrentUserId() function here?
Same for the UserId?
@michalkrzyz can you please check?
There was a problem hiding this comment.
Yes this is what we should do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the new Metadata.CreatedBy field to the new issue match being created in the OnComponentVersionAttachmentToIssue event because without this field it was failing due to the new foreign key constraint on the created_by field.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I tested by running the openstack scanner. Without this change, no issue matches were being created and the app was logging a foreign key constraint error for the issuematch_created_by field in the db. With this change there was no error and issue matches were being created correctly.
Added to documentation?
Checklist