chore(doc):created new folder for storing images related to the produ… #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct design document A discussed in the meeting, created this folder to store images utilised in the document.
|
I think it would make more sense to have a general "assets" folder directly below |
We instead create an assets folder in the doc directory
|
@drochow I have created the new 'assets' folder and deleted the previously created one. |
drochow
approved these changes
Oct 18, 2024
dustindemmerle
pushed a commit
that referenced
this pull request
Oct 23, 2024
#290) * chore(doc):created new folder for storing images related to the product design document A discussed in the meeting, created this folder to store images utilised in the document. * chore(doc):created assets folder * chore(doc):delete product design doc images folder We instead create an assets folder in the doc directory
dustindemmerle
pushed a commit
that referenced
this pull request
Nov 25, 2024
#290) * chore(doc):created new folder for storing images related to the product design document A discussed in the meeting, created this folder to store images utilised in the document. * chore(doc):created assets folder * chore(doc):delete product design doc images folder We instead create an assets folder in the doc directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A discussed in the meeting, created this folder to store images utilised in the document.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist