feat(scanner): Implement K8s scanner #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dorneanu
commented
Aug 27, 2024
dorneanu
commented
- The scanner will use the Kubernetes API to fetch information about:
- pods
- containers
- services (extracted from pods labels)
- Several entities will be created:
- Service
- ComponentInstance
|
@dorneanu please sign your commits! |
drochow
requested changes
Aug 28, 2024
drochow
requested changes
Sep 2, 2024
There was a problem hiding this comment.
This looks good!
I first doubted that grouping by generator name in the scanner is a good idea rather than doing it in the processor. But it's probably a good idea, as in future implementations, this will make it way more straightforward on the processor side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.