Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Python Notebook doing a deeper dive into COG Overview Resampling #95

Merged
merged 16 commits into from
Jan 4, 2024

Conversation

wildintellect
Copy link
Contributor

@wildintellect wildintellect commented Nov 15, 2023

Content was already checked by @kylebarron

  • Verify site builds correctly (including TOC links etc)
  • Should this be a squash merge?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Nov 15, 2023

PR Preview Action v1.4.6
🚀 Deployed preview to https://cloudnativegeo.github.io/cloud-optimized-geospatial-formats-guide/pr-preview/pr-95/
on branch gh-pages at 2024-01-03 21:49 UTC

@kylebarron
Copy link
Member

I usually use squash merge everywhere 🤷‍♂️

Copy link
Collaborator

@zacdezgeo zacdezgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebooks are great! I made some changes in #98 mostly around the text blocks. When we merge that, I'll add my ✅ .

_quarto.yml Show resolved Hide resolved
"cell_type": "markdown",
"id": "8ecd2c7c",
"metadata": {},
"source": [
"## Download a GeoTIFF from EarthData\n",
"\n",
"Note: The whole point of is that we _don't_ download data. So in future examples, we will demonstrate how to access just subsets of data using COG and compare that with a GeoTIFF."
"Note: The whole point is that we _don't_ download data. So, in future examples, we will demonstrate how to access just subsets of data using COG and compare that with a GeoTIFF."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Note: The whole point is that we _don't_ download data. So, in future examples, we will demonstrate how to access just subsets of data using COG and compare that with a GeoTIFF."
"Note: The whole point of the "cloud-optimized" part of Cloud-Optimized GeoTIFF is that we _don't_ download the entire file. So, in future examples, we will demonstrate how to access just subsets of data using COG and compare that with a GeoTIFF."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, forgot to get this fix in (also forgot to squash). Going to open a new PR to cover.

@wildintellect wildintellect merged commit a54ed18 into main Jan 4, 2024
3 checks passed
@wildintellect wildintellect mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants