Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lerc is not lossy unless max_z_error is > 0 #88

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix: lerc is not lossy unless max_z_error is > 0 #88

merged 3 commits into from
Oct 31, 2023

Conversation

blacha
Copy link
Contributor

@blacha blacha commented Oct 30, 2023

When using GDAL with LERC it will default to lossless, unless max_z_error is greater than 0

Also lossless LERC works surprisingly well for non floating point types (eg 8bit RGBA or 16bit RGBi)

kylebarron
kylebarron approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zacdezgeo zacdezgeo changed the base branch from main to staging October 31, 2023 00:03
@zacdezgeo zacdezgeo merged commit c40d3a5 into cloudnativegeo:staging Oct 31, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blacha @kylebarron @zacdezgeo