Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid queueProducers schema #6128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TimoWilhelm
Copy link

@TimoWilhelm TimoWilhelm commented Jun 22, 2024

What this PR solves / how to test

Fixes #5908.

The following commit changes the schema for queueProducers in miniflare but the zod schema still accepts the old Record<string, string> schema which will cause sending to the queue to fail with a non-descriptive error.
66bdad0#diff-0a38fa706f017d0142050f5bcd28eaed913461608cec13a4fa1461af12ff2d65L537

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

@TimoWilhelm TimoWilhelm requested a review from a team as a code owner June 22, 2024 10:41
Copy link

changeset-bot bot commented Jun 22, 2024

⚠️ No Changeset found

Latest commit: 1a9183f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9624887654/npm-package-wrangler-6128

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6128/npm-package-wrangler-6128

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9624887654/npm-package-wrangler-6128 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9624887654/npm-package-create-cloudflare-6128 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9624887654/npm-package-cloudflare-kv-asset-handler-6128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9624887654/npm-package-miniflare-6128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9624887654/npm-package-cloudflare-pages-shared-6128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9624887654/npm-package-cloudflare-vitest-pool-workers-6128

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.1
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
queues Relating to queues
Projects
Status: Other
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Producer sending message to queue throwing Error: Network connection lost in Miniflare
2 participants